Jump to content


resolved

Bug In Ithemes-Exchange/api/pages.php

exchange bug

5 replies to this topic

#1 WildPlatypus

WildPlatypus

    Advanced Member

  • Members
  • Others: Toolkit Educator Edition
  • PipPipPip
  • 49 posts
  • LocationCalifornia

Posted 21 May 2014 - 12:30 PM

There is a bug in /api/pages.php

do_action( 'it_exchnage_register_page', $page, $options );

exchange is spelled incorrectly as exchnage which will likely prevent the hook from being correctly executed.

This bug exists in the current version as of today.  (1.8.2)

I found this bug in the process of trying to figure out why all iThemes plugins fail to correctly display their changelogs from the plugin update window.  

Further (and as reported in my other thread), Exchange shows a Product Description instead of the changelog when clicking on the changelog link, which likely points to the fact that the wordpress readme.txt file being hosted at wordpress.org either fails to include a valid changelog section or is otherwise formatted incorrectly.

Based on a review of the readme.txt included locally with the plugin, it appears to be the former, since there is no == Changelog == section in the readme.txt.  Please follow the Wordpress standards so that users can benefit from being able to see the changelog before updating their plugins.

Please pass this feedback directly to engineering.  Thx.

#2 Ronald

Ronald

    Forum Admin

  • Administrators
  • Others: All Plugins, All Themes, Moderators, Webdesign
  • 30,145 posts

Posted 21 May 2014 - 02:36 PM

Hi,

I will pass it on to the developers, thanks,

Ronald

Join the iThemes Builder Community on Google+.



To ensure that we can process your support request efficiently, ALWAYS include a link to your site, and/or the page your request is related to. Please also read the forum guidelines.



When asking your question/posting your request on the forum, please be as concise and specific as possible. The shorter your request, the more to the point, the more specific, the easier it will be for us to try and help out.


#3 Glenn Ansley

Glenn Ansley

    iThemes Plugin Developer

  • Moderators
  • Others: All Plugins, All Themes, Exchange - Stripe, Toolkit
  • 64 posts
  • LocationWake Forest, NC

Posted 21 May 2014 - 02:39 PM

Thanks for the heads up on the misspelled word. The == Changelog == section isn't required by WordPress. Our readme.txt validates on the .org hosted validator.
We have a public changelog available here: http://ithemes.com/codex/page/Exchange_Changelog and it is linked in the update notification part of our readme.txt

#4 Glenn Ansley

Glenn Ansley

    iThemes Plugin Developer

  • Moderators
  • Others: All Plugins, All Themes, Exchange - Stripe, Toolkit
  • 64 posts
  • LocationWake Forest, NC

Posted 21 May 2014 - 03:15 PM

With that being said, i've updated the readme for you.

#5 WildPlatypus

WildPlatypus

    Advanced Member

  • Members
  • Others: Toolkit Educator Edition
  • PipPipPip
  • 49 posts
  • LocationCalifornia

Posted 21 May 2014 - 03:16 PM

You're welcome.

With all due respect, whether or not the readme.txt validates in its current state is not the issue.  It is missing an important section. And, the == Changelog == section is required if you are hosting the plugin on wordpress.org and expect the update link on the plugin update page of the user's Wordpress dashboard to be able to pull up the changelog info/tab.

A separate, public changelog at your site is nice, but not helpful to users at the moment of upgrade, since it is not tied to the WP plugin update interface at the point when users are going to update their plugin.

Please re-think the approach on this issue.  It should just work when the user clicks the link that's already there. It's common sense and optimal in terms of UX.

http://wordpress.org/news/2009/07/improving-your-plugin-changelogs/
http://wordpress.org/plugins/about/readme.txt

Regards,

WP

#6 WildPlatypus

WildPlatypus

    Advanced Member

  • Members
  • Others: Toolkit Educator Edition
  • PipPipPip
  • 49 posts
  • LocationCalifornia

Posted 21 May 2014 - 03:16 PM

OK - thanks - then you can ignore my simul-post above.  I think it's in everyone's best interest (to fix the changelog)! ;-)



Reply to this Topic


ATTENTION
If this topic is marked RESOLVED or INFORMATION, or if you are NOT experiencing EXACTLY the same issue, please start a new topic to provide the details of your problem. If the solution provided doesn't work for you, you should start a new topic. If you feel this thread contains relevant information, you may include a link to it in your new topic. To ensure that we can process your support request efficiently, ALWAYS include a link to your site, and/or the page your request is related to. When posting your question or request on the forum, please be as concise and specific as possible. The shorter and more to the point you can make your request, the better.

For BackupBuddy related issues, be sure to include the status log from your most recent backup.

CLICK HERE to start a new topic in the Exchange ecommerce plugin forum.


  



Also tagged with one or more of these keywords: resolved, exchange, bug

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users